feat(stats)!: implement additional metric tags in libdd-trace-stats#2170
Draft
duncanpharvey wants to merge 6 commits into
Draft
feat(stats)!: implement additional metric tags in libdd-trace-stats#2170duncanpharvey wants to merge 6 commits into
duncanpharvey wants to merge 6 commits into
Conversation
|
Contributor
📚 Documentation Check Results📦
|
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
Contributor
🔒 Cargo Deny Results📦
|
c020593 to
82959f7
Compare
82959f7 to
9977516
Compare
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
fb6b20d to
b3d13e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
ClientGroupedStats.additional_metric_tagswith the related key/value pairs when the additional metric tag keys are provided.additional_metric_tagsto 4.additional_metrics_tagsto 100 by default and make configurable. Populate withtracer_blocked_valuewhen cardinality limit is exceeded.additional_metric_tagsto 200. Populate withtracer_blocked_valuewhen maximum length limit is exceeded.Motivation
Allow Serverless Compatibility Layer to send additional metric tags on trace stats.
https://datadoghq.atlassian.net/browse/SVLS-8787
Additional Notes
How to test the change?