debug: setconstraint! for MHE and softness parameter arguments now works#387
Merged
Conversation
It was not working at all in the case of linear inequality constraints. I will add constraint violation test to verify this more rigorously.
franckgaga
changed the title
setconstraint! for MHE and softness parameters now worksetconstraint! for MHE and softness parameter arguments now works
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #387 +/- ##
=======================================
Coverage 98.60% 98.60%
=======================================
Files 27 27
Lines 5595 5595
=======================================
Hits 5517 5517
Misses 78 78 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting the softness parameters$\mathbf{c_{(\bullet)}}$ was not working at all for the $\varepsilon$ is a the beginning of the decision vector for the MHE, so the weights is the first column of the $\mathbf{A}$ matrices for the inequality constraints.
MovingHorizonEstimatorin the case of linear inequality constraints. The slack variableI will add new constraint violation tests to verify this more rigorously.