refactor(sonar): fix cpp:S6197, cpp:S1066, and cpp:S1181

[ReenigneArcher]

Description

Fixes sonar issues cpp:S6197, cpp:S1066, and cpp:S1181

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

• feat: New feature (non-breaking change which adds functionality)
• fix: Bug fix (non-breaking change which fixes an issue)
• docs: Documentation only changes
• style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
• refactor: Code change that neither fixes a bug nor adds a feature
• perf: Code change that improves performance
• test: Adding missing tests or correcting existing tests
• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Other changes that don't modify src or test files
• revert: Reverts a previous commit
• BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

• Code follows the style guidelines of this project
• Code has been self-reviewed
• Code has been commented, particularly in hard-to-understand areas
• Code docstring/documentation-blocks for new or existing methods/components have been added or updated
• Unit tests have been added or updated for any new or modified functionality

AI Usage

• None: No AI tools were used in creating this PR
• Light: AI provided minor assistance (formatting, simple suggestions)
• Moderate: AI helped with code generation or debugging specific parts
• Heavy: AI generated most or all of the code changes

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

❌ Patch coverage is 85.71429% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.97%. Comparing base (16daddf) to head (762415d).
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
src/common/file_settings_persistence.cpp	33.33%	2 Missing ⚠️
...mon/include/display_device/detail/json_converter.h	90.47%	1 Missing and 1 partial ⚠️
...rc/common/include/display_device/retry_scheduler.h	75.00%	0 Missing and 2 partials ⚠️
src/windows/win_api_layer.cpp	66.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
- Coverage   93.16%   92.97%   -0.20%     
==========================================
  Files          35       35              
  Lines        2268     2276       +8     
  Branches     1107     1111       +4     
==========================================
+ Hits         2113     2116       +3     
+ Misses         68       63       -5     
- Partials       87       97      +10     

Flag	Coverage Δ
Linux	92.68% <76.66%> (-1.16%)	⬇️
Windows-AMD64	91.50% <78.26%> (-0.34%)	⬇️
Windows-ARM64	64.83% <44.89%> (-0.42%)	⬇️
macOS	72.55% <36.36%> (-1.45%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...de/display_device/detail/json_serializer_details.h	100.00% <100.00%> (ø)
src/windows/settings_manager_apply.cpp	98.70% <100.00%> (-0.05%)	⬇️
src/windows/win_api_utils.cpp	99.58% <100.00%> (-0.01%)	⬇️
src/windows/win_display_device_topology.cpp	97.95% <100.00%> (ø)
src/windows/win_api_layer.cpp	75.59% <66.66%> (-0.12%)	⬇️
src/common/file_settings_persistence.cpp	58.13% <33.33%> (ø)
...mon/include/display_device/detail/json_converter.h	88.88% <90.47%> (-11.12%)	⬇️
...rc/common/include/display_device/retry_scheduler.h	97.41% <75.00%> (+0.04%)	⬆️

---

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16daddf...762415d. Read the comment docs.