Skip to content

refactor(sonar): fix cpp:S6197, cpp:S1066, and cpp:S1181#264

Merged
ReenigneArcher merged 1 commit into
masterfrom
refactor/sonar/multiple-fixes
Jun 9, 2026
Merged

refactor(sonar): fix cpp:S6197, cpp:S1066, and cpp:S1181#264
ReenigneArcher merged 1 commit into
masterfrom
refactor/sonar/multiple-fixes

refactor(sonar): fix cpp:S6197, cpp:S1066, and cpp:S1181

762415d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 9, 2026 in 1s

92.97% (-0.20%) compared to 16daddf

View this Pull Request on Codecov

92.97% (-0.20%) compared to 16daddf

Details

Codecov Report

❌ Patch coverage is 85.71429% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.97%. Comparing base (16daddf) to head (762415d).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/common/file_settings_persistence.cpp 33.33% 2 Missing ⚠️
...mon/include/display_device/detail/json_converter.h 90.47% 1 Missing and 1 partial ⚠️
...rc/common/include/display_device/retry_scheduler.h 75.00% 0 Missing and 2 partials ⚠️
src/windows/win_api_layer.cpp 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
- Coverage   93.16%   92.97%   -0.20%     
==========================================
  Files          35       35              
  Lines        2268     2276       +8     
  Branches     1107     1111       +4     
==========================================
+ Hits         2113     2116       +3     
+ Misses         68       63       -5     
- Partials       87       97      +10     
Files with missing lines Coverage Δ
...de/display_device/detail/json_serializer_details.h 100.00% <100.00%> (ø)
src/windows/settings_manager_apply.cpp 98.70% <100.00%> (-0.05%) ⬇️
src/windows/win_api_utils.cpp 99.58% <100.00%> (-0.01%) ⬇️
src/windows/win_display_device_topology.cpp 97.95% <100.00%> (ø)
src/windows/win_api_layer.cpp 75.59% <66.66%> (-0.12%) ⬇️
src/common/file_settings_persistence.cpp 58.13% <33.33%> (ø)
...mon/include/display_device/detail/json_converter.h 88.88% <90.47%> (-11.12%) ⬇️
...rc/common/include/display_device/retry_scheduler.h 97.41% <75.00%> (+0.04%) ⬆️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16daddf...762415d. Read the comment docs.