[Runtime][Tests] Fix contrib wheel tests#19714
Merged
Merged
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Member
|
i think we can remove support for bits==1 and bits==4 since the current logic did not cover that and we did not have such usage, this will simplify the impl. we can inline run_test_script into caller |
tqchen
approved these changes
Jun 10, 2026
tqchen
pushed a commit
that referenced
this pull request
Jun 12, 2026
…sage (#19748) #19714 intentionally removed packed sub-byte (bits 1/4) support from RandomEngine after the int4 fill path was found to write past the allocated storage, but left "int4" in test_random_fill's dtype list, so the test now fails with InternalError on every run. Remove it from the list to match the supported set. Also cast dtype.code / dtype.bits to int in the unsupported-dtype error messages: both fields are uint8_t and were streamed as (invisible) characters, e.g. "Doesn't support dtype code dtype bits".
MasterJH5574
pushed a commit
to MasterJH5574/tvm
that referenced
this pull request
Jun 15, 2026
This pr fixes two contrib test failures that show up when running source-tree tests against the `apache-tvm` wheel. - Launch the pickle memoize helper script with `sys.executable` so subprocesses use the same Python environment as pytest. - Fix `tvm.contrib.random.random_fill` for packed sub-byte dtypes by using the actual tensor storage size instead of the logical element count. ## Root Cause `tests/python/contrib/test_memoize.py` executed `pickle_memoize_script.py` directly. In a wheel test environment, the shebang can resolve to a different Python than the active wheel venv, causing `ModuleNotFoundError: No module named 'tvm'`. `random_fill` used the product of tensor shape as the number of values to write. For packed dtypes such as `int4`, two logical elements share one byte, so this wrote past the allocated storage and caused native heap corruption / process abort. --------- Co-authored-by: tqchen <tianqi.tchen@gmail.com> (cherry picked from commit 0ff0f85)
MasterJH5574
pushed a commit
to MasterJH5574/tvm
that referenced
this pull request
Jun 15, 2026
…sage (apache#19748) apache#19714 intentionally removed packed sub-byte (bits 1/4) support from RandomEngine after the int4 fill path was found to write past the allocated storage, but left "int4" in test_random_fill's dtype list, so the test now fails with InternalError on every run. Remove it from the list to match the supported set. Also cast dtype.code / dtype.bits to int in the unsupported-dtype error messages: both fields are uint8_t and were streamed as (invisible) characters, e.g. "Doesn't support dtype code dtype bits". (cherry picked from commit 59f8283)
MasterJH5574
pushed a commit
to MasterJH5574/tvm
that referenced
this pull request
Jun 15, 2026
This pr fixes two contrib test failures that show up when running source-tree tests against the `apache-tvm` wheel. - Launch the pickle memoize helper script with `sys.executable` so subprocesses use the same Python environment as pytest. - Fix `tvm.contrib.random.random_fill` for packed sub-byte dtypes by using the actual tensor storage size instead of the logical element count. ## Root Cause `tests/python/contrib/test_memoize.py` executed `pickle_memoize_script.py` directly. In a wheel test environment, the shebang can resolve to a different Python than the active wheel venv, causing `ModuleNotFoundError: No module named 'tvm'`. `random_fill` used the product of tensor shape as the number of values to write. For packed dtypes such as `int4`, two logical elements share one byte, so this wrote past the allocated storage and caused native heap corruption / process abort. --------- Co-authored-by: tqchen <tianqi.tchen@gmail.com> (cherry picked from commit 0ff0f85)
MasterJH5574
pushed a commit
to MasterJH5574/tvm
that referenced
this pull request
Jun 15, 2026
…sage (apache#19748) apache#19714 intentionally removed packed sub-byte (bits 1/4) support from RandomEngine after the int4 fill path was found to write past the allocated storage, but left "int4" in test_random_fill's dtype list, so the test now fails with InternalError on every run. Remove it from the list to match the supported set. Also cast dtype.code / dtype.bits to int in the unsupported-dtype error messages: both fields are uint8_t and were streamed as (invisible) characters, e.g. "Doesn't support dtype code dtype bits". (cherry picked from commit 59f8283)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr fixes two contrib test failures that show up when running source-tree tests against the
apache-tvmwheel.sys.executableso subprocesses use the same Python environment as pytest.tvm.contrib.random.random_fillfor packed sub-byte dtypes by using the actual tensor storage size instead of the logical element count.Root Cause
tests/python/contrib/test_memoize.pyexecutedpickle_memoize_script.pydirectly. In a wheel test environment, the shebang can resolve to a different Python than the active wheel venv, causingModuleNotFoundError: No module named 'tvm'.random_fillused the product of tensor shape as the number of values to write. For packed dtypes such asint4, two logical elements share one byte, so this wrote past the allocated storage and caused native heap corruption / process abort.