Skip to content

Fix ament_package build failing on older python versions#372

Closed
Amronos wants to merge 1 commit into
rollingfrom
fix-371
Closed

Fix ament_package build failing on older python versions#372
Amronos wants to merge 1 commit into
rollingfrom
fix-371

Conversation

@Amronos

@Amronos Amronos commented Jul 16, 2026

Copy link
Copy Markdown
Member

I have added a patch file to the codebase that should help fix #371 by removing the Traversable import and its usage.
It's a bit different from the solutions suggested in #371, but I feel like this is the most maintainable way to do it.

@mergify

mergify Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@Amronos
Amronos marked this pull request as draft July 16, 2026 01:03
@Narukara

Copy link
Copy Markdown
Contributor

I do not think this patch-based workaround is a good approach. The patch is fragile, and almost any upstream change could make it fail to apply.

I checked REP 2000, and it lists Python 3.9 as the minimum supported version for Kilted Kaiju. It also notes that, as of May 2025, Rolling Ridley targets the same platforms as ROS 2 Kilted Kaiju. This suggests that the upstream change may violate the documented platform support requirements.

I believe we should consider reporting this to the upstream repository and asking them to fix the issue by restoring support for the documented compatibility range.

@Amronos

Amronos commented Jul 16, 2026

Copy link
Copy Markdown
Member Author

The rep is definitely outdated. ROS 2 Lyrical Luth was recently released, and it bumps the minimum Python version to 3.12. See this.

@Narukara

Copy link
Copy Markdown
Contributor

The rep is definitely outdated. ROS 2 Lyrical Luth was recently released, and it bumps the minimum Python version to 3.12. See this.

Thanks for the correction. Would you be in favor of dropping support for ESP-IDF 5.2 and 5.3 on the rolling branch? 🤔

@Amronos

Amronos commented Jul 16, 2026

Copy link
Copy Markdown
Member Author

That does sound like a good idea to me. After this change, I will create the necessary PRs and changes to also branch-off to lyrical.

@Amronos Amronos closed this Jul 16, 2026
@Amronos
Amronos deleted the fix-371 branch July 16, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI fails on ESP-IDF v5.2/v5.3 due to ament_package requiring Python 3.11+

2 participants