Conversation
|
Tick the box to add this pull request to the merge queue (same as
|
|
I do not think this patch-based workaround is a good approach. The patch is fragile, and almost any upstream change could make it fail to apply. I checked REP 2000, and it lists Python 3.9 as the minimum supported version for Kilted Kaiju. It also notes that, as of May 2025, Rolling Ridley targets the same platforms as ROS 2 Kilted Kaiju. This suggests that the upstream change may violate the documented platform support requirements. I believe we should consider reporting this to the upstream repository and asking them to fix the issue by restoring support for the documented compatibility range. |
|
The rep is definitely outdated. ROS 2 Lyrical Luth was recently released, and it bumps the minimum Python version to 3.12. See this. |
Thanks for the correction. Would you be in favor of dropping support for ESP-IDF 5.2 and 5.3 on the rolling branch? 🤔 |
|
That does sound like a good idea to me. After this change, I will create the necessary PRs and changes to also branch-off to lyrical. |
I have added a patch file to the codebase that should help fix #371 by removing the
Traversableimport and its usage.It's a bit different from the solutions suggested in #371, but I feel like this is the most maintainable way to do it.