Release New Version#2316
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThree example ChangesExample Dependency Version Downgrade
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
⚠️ Not ready to approve
The example workspaces are pinned to 1.15.2 while the workspace packages in this release are 1.16.0, which can cause pnpm to install older registry packages instead of linking the local workspace versions.
Pull request overview
This Changesets-generated release PR prepares the repo for publishing the 1.16.0 set of packages to npm; the diff shown here updates dependency pins inside the example workspaces.
Changes:
- Updated
examples/*package manifests to pinenssdk,enskit,ensskills, andenscliversions. - (As proposed) Downgraded those example pins from
1.16.0to1.15.2, which risks pulling registry packages instead of linking workspace packages during the release.
File summaries
| File | Description |
|---|---|
| examples/ensskills-example/package.json | Adjusts enscli/ensskills devDependency pins. |
| examples/enssdk-example/package.json | Adjusts enssdk dependency pin. |
| examples/enskit-react-example/package.json | Adjusts enskit/enssdk dependency pins. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 3
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Greptile SummaryThis Changesets release PR targets v1.16.0 across the monorepo, including
Confidence Score: 3/5The only code changes are three example package.json files, but they move in the wrong direction — downgrading dependencies that the parent commit on main had already advanced to 1.16.0. A manual "fix: example version references" commit reverts all three example packages' workspace-package dependencies from 1.16.0 back to 1.15.2, directly contradicting the Changesets-generated changelog included in this very PR. Once 1.16.0 is published the examples would immediately be one version behind, silently testing the old API surface. All three example package.json files warrant a second look: examples/enskit-react-example/package.json, examples/enssdk-example/package.json, and examples/ensskills-example/package.json. Important Files Changed
Sequence Diagram%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
participant main as main branch
participant pr2282 as PR #2282 (merged)
participant pr2316 as PR #2316 (this PR)
participant npm as npm registry
main->>pr2282: "enssdk@1.15.2, examples→1.15.2"
pr2282->>main: "Merge: enssdk@1.16.0, examples→1.16.0"
main->>pr2316: Changesets creates release PR
note over pr2316: Manual commit fix: example version references reverts examples from 1.16.0 to 1.15.2
pr2316-->>npm: publish 1.16.0 on merge
note over npm: enssdk@1.16.0 published
note over pr2316: examples still pin 1.15.2
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
participant main as main branch
participant pr2282 as PR #2282 (merged)
participant pr2316 as PR #2316 (this PR)
participant npm as npm registry
main->>pr2282: "enssdk@1.15.2, examples→1.15.2"
pr2282->>main: "Merge: enssdk@1.16.0, examples→1.16.0"
main->>pr2316: Changesets creates release PR
note over pr2316: Manual commit fix: example version references reverts examples from 1.16.0 to 1.15.2
pr2316-->>npm: publish 1.16.0 on merge
note over npm: enssdk@1.16.0 published
note over pr2316: examples still pin 1.15.2
Reviews (1): Last reviewed commit: "fix: example version references" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| "@pierre/trees": "1.0.0-beta.4", | ||
| "enskit": "1.16.0", | ||
| "enssdk": "1.16.0", | ||
| "enskit": "1.15.2", | ||
| "enssdk": "1.15.2", |
There was a problem hiding this comment.
The diff reverts enskit and enssdk from 1.16.0 → 1.15.2, which is the inverse of what a "Release New Version" PR should do. The PR description's auto-generated changelog explicitly states these example packages are being updated because of enssdk@1.16.0/enskit@1.16.0 dependency bumps, yet the actual committed change goes in the opposite direction. The previous release PR (#2282) — which is the direct parent commit on main — already bumped these references to 1.16.0. If this PR is merged and 1.16.0 is published, the examples will ship referencing the prior published version (1.15.2) rather than the just-released one, making them stale the moment they land. The same problem exists in examples/enssdk-example/package.json (enssdk) and examples/ensskills-example/package.json (enscli + ensskills).
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or setup this action to publish automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@ensnode/ensdb-sdk@1.16.0
Minor Changes
09b4aa5Thanks @shrugs! - Add a(value, coinType)index onresolver_address_recordsto support reverse lookups of the Names whoseaddr()record points at a given address. PowersAccount.nameReferencesin the Omnigraph API.Patch Changes
ensskills@1.16.0
Minor Changes
7f7627aThanks @shrugs! - Theenssdkandenskitskills are now fully authored (previously stubs):enssdkcovers the typed ENS Omnigraph client (gql.tada), hashing, normalization, and interpretation primitives for TypeScript integrations;enskitcovers building ENS React UIs (provider setup, typed Omnigraph hooks, caching, Relay pagination). Theens-protocolskill also gained the Subgraph-Interpreted Label concept (why subgraph-compatible APIs may return an Encoded LabelHash where the Omnigraph returns the literal label).Patch Changes
7f7627aThanks @shrugs! - Theomnigraphskill now explains Protocol Acceleration (resolve is accelerated by default, transparent protocol-compliant fallback, theacceleration { requested attempted }introspection) and the indexing-status/503 contract (when an instance responds 503 and how to check progress withenscli ensnode indexing-status). Theens-protocolskill now defines the ENS Namespace concept (a logically-isolated set of names spanning many chains, not 1:1 with an L1 chain).@ensnode/datasources@1.16.0
Patch Changes
@namehash/ens-referrals@1.16.0
Patch Changes
enscli@1.16.0
Patch Changes
enskit@1.16.0
Patch Changes
@ensnode/ensnode-sdk@1.16.0
Patch Changes
@ensnode/ensrainbow-sdk@1.16.0
Patch Changes
@namehash/namehash-ui@1.16.0
Patch Changes
enssdk@1.16.0
@ensnode/ponder-sdk@1.16.0
@ensnode/ponder-subgraph@1.16.0
ensapi@1.16.0
Minor Changes
09b4aa5Thanks @shrugs! - Omnigraph API: AddsAccount.nameReferences, surfacing the Names whose indexedaddr()record points at the Account, optionally scoped to a singleCoinTypeviawhere: { coinType }. Reflects literally-indexed, Canonical Domains only: records whose node has no canonical Domain are omitted, and Forward Resolution / CCIP-Read and ENSIP-19 address record defaulting are not applied.Patch Changes
#2285
ba68bbeThanks @sevenzing! - - AddDomain.resolve.profile.contenthashinterpretationUpdated dependencies [
09b4aa5]:ensadmin@1.16.0
Patch Changes
ensindexer@1.16.0
Patch Changes
#2280
dff338cThanks @shrugs! - ENSIndexer now re-derives a Resolver's ENSIP-10IExtendedResolversupport when a known proxy Resolver emits an EIP-1967Upgradedevent, instead of fixing the value once at first visibility. Proxy Resolvers that activateIExtendedResolvervia a post-assignment upgrade (e.g. the 3DNS Resolver behind.box) were stuckextended = falseforever, silently breaking wildcard resolution for affected names.Updated dependencies [
09b4aa5]:ensrainbow@1.16.0
Patch Changes
fallback-ensapi@1.16.0
Patch Changes
@docs/ensnode@1.16.0
Patch Changes
@docs/ensrainbow@1.16.0
Patch Changes
@ensnode/enskit-react-example@0.0.11
Patch Changes
@ensnode/enssdk-example@0.0.5
Patch Changes
@ensnode/integration-test-env@1.16.0
Patch Changes
09b4aa5]:@ensnode/ensindexer-perf-testing@1.16.0
@ensnode/shared-configs@1.16.0