Skip to content

Release New Version #2316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tk-o merged 1 commit into from
Jun 18, 2026
Merged

Release New Version #2316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/enskit-react-example/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
},
"dependencies": {
"@pierre/trees": "1.0.0-beta.4",
"enskit": "1.16.0",
"enssdk": "1.16.0",
"enskit": "1.15.2",
"enssdk": "1.15.2",
Comment thread
tk-o marked this conversation as resolved.
Comment on lines 15 to +17

@greptile-apps greptile-apps Bot Jun 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Example dependencies downgraded, not upgraded

The diff reverts enskit and enssdk from 1.16.0 → 1.15.2, which is the inverse of what a "Release New Version" PR should do. The PR description's auto-generated changelog explicitly states these example packages are being updated because of enssdk@1.16.0/enskit@1.16.0 dependency bumps, yet the actual committed change goes in the opposite direction. The previous release PR (#2282) — which is the direct parent commit on main — already bumped these references to 1.16.0. If this PR is merged and 1.16.0 is published, the examples will ship referencing the prior published version (1.15.2) rather than the just-released one, making them stale the moment they land. The same problem exists in examples/enssdk-example/package.json (enssdk) and examples/ensskills-example/package.json (enscli + ensskills).

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

"react": "catalog:",
"react-dom": "catalog:",
"react-router": "^7.17.0"
Expand Down
2 changes: 1 addition & 1 deletion examples/enssdk-example/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"generate:gqlschema": "gql.tada generate-output"
},
"dependencies": {
"enssdk": "1.16.0"
"enssdk": "1.15.2"
Comment thread
tk-o marked this conversation as resolved.
},
"devDependencies": {
"@types/node": "catalog:",
Expand Down
4 changes: 2 additions & 2 deletions examples/ensskills-example/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
"prepare": "skills-npm --cwd ."
},
"devDependencies": {
"enscli": "1.16.0",
"ensskills": "1.16.0",
"enscli": "1.15.2",
"ensskills": "1.15.2",
Comment thread
tk-o marked this conversation as resolved.
"skills-npm": "^1"
}
}
Loading