NO-ISSUE: configure-vm.sh: Wait for firewall & install gettext

[pmtk]

Summary by CodeRabbit

• Bug Fixes
  • Improved firewall setup reliability by waiting briefly for the firewall service to become ready before applying configuration changes.
  • Reduced the chance of setup failures caused by running firewall commands too early.
• Chores
  • Added an additional build dependency required during virtual machine build setup.

[coderabbitai]

Walkthrough

configure-vm.sh now installs gettext during build dependency setup and waits for firewall-cmd --state to succeed before applying permanent firewall rules.

Changes

VM configuration updates

Layer / File(s)	Summary
Build dependency install scripts/devenv-builder/configure-vm.sh	Adds gettext to the existing build dependency install list.
Firewall readiness wait scripts/devenv-builder/configure-vm.sh	Retries firewall-cmd --state before permanent rule application, then proceeds with the existing firewall configuration steps.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

ready-for-human-review

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	No Ginkgo test titles were added or changed; the PR only adjusts a shell script and non-Ginkgo tests/helpers.
Test Structure And Quality	✅ Passed	PR only changes scripts/devenv-builder/configure-vm.sh; no Ginkgo tests were touched, so the test-structure check is not applicable.
Microshift Test Compatibility	✅ Passed	Only scripts/devenv-builder/configure-vm.sh changed; no new Ginkgo e2e tests or MicroShift-unsupported APIs were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Only scripts/devenv-builder/configure-vm.sh changed; no new Ginkgo e2e tests or SNO-sensitive test logic were added.
Topology-Aware Scheduling Compatibility	✅ Passed	Only scripts/devenv-builder/configure-vm.sh changed; it installs gettext and waits for firewalld, with no manifests/controllers or scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	PR only changes scripts/devenv-builder/configure-vm.sh; no OTE binary entrypoints or stdout-JSON contract code were modified.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR only changes scripts/devenv-builder/configure-vm.sh; no new Ginkgo/e2e tests were added, so the IPv6/disconnected-network check is not applicable.
No-Weak-Crypto	✅ Passed	Touched script only adds gettext and firewall-wait logic; no weak crypto primitives, custom crypto, or secret/token comparisons found.
Container-Privileges	✅ Passed	PR only changes scripts/devenv-builder/configure-vm.sh; no container/K8s manifests or privilege settings were added.
No-Sensitive-Data-In-Logs	✅ Passed	The changed script only adds a package install and a silent firewalld readiness wait; no new logs print secrets, tokens, PII, or hostnames.
Title check	✅ Passed	The title clearly reflects the main changes: waiting for firewalld readiness and adding gettext in configure-vm.sh.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@scripts/devenv-builder/configure-vm.sh`:
- Around line 350-353: Add a hard failure in the firewall readiness polling so
the script does not continue after timeout. In the polling block that uses the
`for _ in $(seq 30)` loop and `sudo firewall-cmd --state`, track whether a
successful state check occurred, and after the loop explicitly `return 1` or
`exit 1` if readiness was never reached. Use the existing polling logic in
`configure-vm.sh` to gate the commands that follow on that success condition.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: ad82fa67-57fc-4913-9629-2914c687eac7

📥 Commits

Reviewing files that changed from the base of the PR and between bfeabef and c93a927.

📒 Files selected for processing (1)

• scripts/devenv-builder/configure-vm.sh

[openshift-ci]

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@pmtk: This pull request explicitly references no jira issue.

Details

In response to this:

Summary by CodeRabbit

• Bug Fixes
• Improved firewall setup reliability by waiting briefly for the firewall service to become ready before applying configuration changes.
• Reduced the chance of setup failures caused by running firewall commands too early.
• Chores
• Added an additional build dependency required during virtual machine build setup.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[kasturinarra]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kasturinarra, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [kasturinarra,pmtk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pmtk]

/verified by ci

[openshift-ci-robot]

@pmtk: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.