Skip to content

NO-ISSUE: configure-vm.sh: Wait for firewall & install gettext #6929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 2 commits into from
Jun 24, 2026
+5 −1
Merged

NO-ISSUE: configure-vm.sh: Wait for firewall & install gettext #6929

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c93a927
After enabling firewalld wait before commands
pmtk Jun 24, 2026
bb07ec3
Install gettext - build dep
pmtk Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion scripts/devenv-builder/configure-vm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ function install_build_deps() {
if ${DNF_UPDATE}; then
"${DNF_RETRY}" "update" "--nobest"
fi
"${DNF_RETRY}" "install" "gcc git golang cockpit make jq selinux-policy-devel rpm-build jq bash-completion avahi-tools createrepo"
"${DNF_RETRY}" "install" "gcc git golang cockpit make jq selinux-policy-devel rpm-build jq bash-completion avahi-tools createrepo gettext"

# run only if booted with systemd
[[ -d /run/systemd/system ]] && sudo systemctl enable --now cockpit.socket
Expand Down Expand Up @@ -347,6 +347,10 @@ function build_and_install_microshift_rpms() {
function configure_firewall() {
"${DNF_RETRY}" "install" "firewalld"
sudo systemctl enable firewalld --now
for _ in $(seq 30) ; do
sudo firewall-cmd --state &>/dev/null && break
sleep 1
done
Comment thread
coderabbitai[bot] marked this conversation as resolved.
sudo firewall-cmd --permanent --zone=trusted --add-source=10.42.0.0/16
sudo firewall-cmd --permanent --zone=trusted --add-source=169.254.169.1
sudo firewall-cmd --permanent --zone=trusted --add-source=fd01::/48
Expand Down