Skip to content

fix(ci): changesets publish args#2304

Merged
lightwalker-eth merged 2 commits into
mainfrom
fix/changesets-publish-args
Jun 16, 2026
Merged

fix(ci): changesets publish args#2304
lightwalker-eth merged 2 commits into
mainfrom
fix/changesets-publish-args

Conversation

@tk-o

@tk-o tk-o commented Jun 16, 2026

Copy link
Copy Markdown
Member

This is a follow up PR to #2303 as updated @changesets/cli dependency enforces new validation rules. The changeset publish command was never meant to include the --snapshot argument, as the that argument belongs solely to the changeset version command (see changesets/changesets#1578).

Also, this PR updates some dependency version to resolve security audit issues.

Copilot AI review requested due to automatic review settings June 16, 2026 17:37
@vercel

vercel Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
admin.ensnode.io Ready Ready Preview, Comment Jun 16, 2026 5:37pm
enskit-react-example.ensnode.io Ready Ready Preview, Comment Jun 16, 2026 5:37pm
ensnode.io Ready Ready Preview, Comment Jun 16, 2026 5:37pm
ensrainbow.io Ready Ready Preview, Comment Jun 16, 2026 5:37pm

@changeset-bot

changeset-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 7421c80

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tk-o tk-o changed the title Fix/changesets publish args fix(ci): changesets publish args Jun 16, 2026
@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Two independent maintenance changes: the release preview CI workflow removes the --snapshot flag from pnpm changeset publish while keeping --no-git-tag and the custom --tag; and the astro catalog entry in pnpm-workspace.yaml is bumped from ^6.3.3 to ^6.4.7.

Changes

Release workflow and dependency updates

Layer / File(s) Summary
Remove --snapshot from release preview publish
.github/workflows/release_preview.yml
The pnpm changeset publish command drops the --snapshot flag while retaining --no-git-tag and the custom --tag argument.
Bump astro catalog version
pnpm-workspace.yaml
The astro catalog entry is updated from ^6.3.3 to ^6.4.7.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A snapshot removed, a flag set free,
While astro hops up to 6.4.7 with glee! 🐇
The workspace catalog now gleams so bright,
And publish commands are finally right.
Small hops make the whole meadow tight! 🌿

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is missing most required template sections, including detailed summary bullets, explicit 'Why' section with issue links, 'Testing' section, and the Pre-Review Checklist. Complete the PR description using the provided template: add 1-3 bullet points for what changed, explain why in a dedicated section with relevant links, describe testing approach, and check both blocking pre-review checklist items.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title directly describes the main change: fixing CI by correcting changesets publish arguments, which is the primary focus of the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/changesets-publish-args

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the release preview GitHub Actions workflow to comply with newer @changesets/cli validation rules by removing an invalid --snapshot flag from changeset publish, while also bumping the repo’s Astro version (and associated lockfile entries) as part of dependency/security maintenance.

Changes:

  • Remove --snapshot from pnpm changeset publish in the release preview workflow (snapshot is handled by changeset version --snapshot).
  • Bump astro from ^6.3.3 to ^6.4.7 in the workspace catalog.
  • Update pnpm-lock.yaml accordingly (transitive updates associated with the Astro bump).

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
pnpm-workspace.yaml Bumps the catalog Astro version to ^6.4.7.
pnpm-lock.yaml Updates lockfile entries to reflect Astro 6.4.7 and related dependency graph changes.
.github/workflows/release_preview.yml Removes the invalid --snapshot flag from changeset publish while keeping snapshot versioning in the prior step.
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/release_preview.yml
@tk-o

tk-o commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

@greptile review

@greptile-apps

greptile-apps Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR removes the invalid --snapshot argument from the changeset publish command in the preview release workflow and bumps astro from 6.3.3 to 6.4.7 along with related dependency updates to address security audit issues.

  • CI fix: --snapshot is a changeset version-only flag; passing it to changeset publish caused newer @changesets/cli validation to error out. The changeset version --snapshot step (line 201) retains the flag correctly, so snapshot versioning is unaffected.
  • Dependency bump: astro catalog version updated to ^6.4.7, pulling in updated @astrojs/internal-helpers, @astrojs/markdown-remark, and patches to @babel/parser/@babel/types.

Confidence Score: 5/5

This PR is safe to merge — it corrects an incorrect CLI argument and applies routine dependency updates with no functional or behavioral risk.

The workflow change is a one-line removal of an argument that was already rejected by the updated @changesets/cli; the snapshot versioning step still uses the flag correctly, so the overall release flow remains intact. The dependency bumps are patch/minor updates with a straightforward lock file update.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/release_preview.yml Removes invalid --snapshot flag from changeset publish; the flag is correctly kept on the changeset version step.
pnpm-workspace.yaml Bumps astro catalog pin from ^6.3.3 to ^6.4.7 to pick up security fixes.
pnpm-lock.yaml Lock file updated to reflect astro 6.4.7 upgrade and @babel/parser/@babel/types patch bumps; no unexpected additions.

Sequence Diagram

%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
    participant GH as GitHub Actions
    participant CS as changesets CLI
    participant NPM as npm Registry

    GH->>CS: "changeset version --snapshot <tag>"
    Note over CS: Creates snapshot versions<br/>(--snapshot is valid here)
    CS-->>GH: packages versioned

    GH->>CS: "changeset publish --no-git-tag --tag <dist-tag>"
    Note over CS: Publishes to npm<br/>(--snapshot removed — was invalid)
    CS->>NPM: publish packages with dist-tag
    NPM-->>CS: published
    CS-->>GH: success + published version
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
    participant GH as GitHub Actions
    participant CS as changesets CLI
    participant NPM as npm Registry

    GH->>CS: "changeset version --snapshot <tag>"
    Note over CS: Creates snapshot versions<br/>(--snapshot is valid here)
    CS-->>GH: packages versioned

    GH->>CS: "changeset publish --no-git-tag --tag <dist-tag>"
    Note over CS: Publishes to npm<br/>(--snapshot removed — was invalid)
    CS->>NPM: publish packages with dist-tag
    NPM-->>CS: published
    CS-->>GH: success + published version
Loading

Reviews (2): Last reviewed commit: "Address audit issues reported by OSV sca..." | Re-trigger Greptile

@tk-o tk-o marked this pull request as ready for review June 16, 2026 17:50
@tk-o tk-o requested a review from a team as a code owner June 16, 2026 17:50
@lightwalker-eth lightwalker-eth merged commit 15a8edf into main Jun 16, 2026
25 checks passed
@lightwalker-eth lightwalker-eth deleted the fix/changesets-publish-args branch June 16, 2026 17:58
@tk-o tk-o restored the fix/changesets-publish-args branch June 16, 2026 18:33
@tk-o tk-o deleted the fix/changesets-publish-args branch June 16, 2026 18:35
@tk-o tk-o restored the fix/changesets-publish-args branch June 16, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants