Skip to content

HYPERFLEET-1351 - fix: disable gomod digest updates in manager-scoped config#253

Merged
openshift-merge-bot[bot] merged 1 commit into
mainfrom
HYPERFLEET-1351-fix-renovate-digest-config
Jul 14, 2026
Merged

HYPERFLEET-1351 - fix: disable gomod digest updates in manager-scoped config#253
openshift-merge-bot[bot] merged 1 commit into
mainfrom
HYPERFLEET-1351-fix-renovate-digest-config

Conversation

@rafabene

Copy link
Copy Markdown
Member

Summary

  • Moved gomod digest and indirect disable rules from top-level packageRules to manager-scoped gomod.packageRules
  • This fixes an issue where MintMaker's global config was overriding the repo's disable rules due to Renovate's specificity hierarchy (manager-scoped rules take precedence over top-level rules)
  • No functional changes to minor/patch grouping or docker image grouping

JIRA

https://redhat.atlassian.net/browse/HYPERFLEET-1351

@openshift-ci openshift-ci Bot requested review from Ruclo and sherine-k July 13, 2026 22:49
@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

The Renovate configuration moves Go module rules disabling digest updates and indirect dependency updates into a top-level gomod.packageRules block. The existing top-level package grouping rule remains in packageRules.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: sherine-k, ruclo

🚥 Pre-merge checks | ✅ 11
✅ Passed checks (11 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Sec-02: Secrets In Log Output ✅ Passed Only renovate.json changed; no slog/log/zap/fmt.Print* statements or token/password/credential/secret fields found. CWE-532 not triggered.
No Hardcoded Secrets ✅ Passed renovate.json adds only Renovate config; scan found no hardcoded credentials, tokens, passwords, embedded creds, or long base64 strings (CWE-798/CWE-259).
No Weak Cryptography ✅ Passed renovate.json only moves Renovate rules; no banned primitives or secret comparisons appear, so no CWE-327/CWE-208 issue.
No Injection Vectors ✅ Passed Only renovate.json changed; it contains no SQL, exec.Command, template.HTML, or yaml.Unmarshal paths, so no CWE-89/CWE-78/CWE-79/CWE-502 injection vector.
No Privileged Containers ✅ Passed Only renovate.json changed; no manifests/templates/Dockerfiles were modified, and no privileged settings were introduced. CWE-250/CWE-732 not implicated.
No Pii Or Sensitive Data In Logs ✅ Passed Only renovate.json changed; no slog/logr/zap/fmt.Print* calls or log payloads were added. No CWE-532 exposure found.
Title check ✅ Passed The title accurately describes the main change: moving gomod digest disable rules into manager-scoped config.
Description check ✅ Passed The description matches the changeset and explains the Renovate rule scope change and its rationale.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch HYPERFLEET-1351-fix-renovate-digest-config
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch HYPERFLEET-1351-fix-renovate-digest-config

Comment @coderabbitai help to get the list of available commands.

@hyperfleet-ci-bot

Copy link
Copy Markdown

Risk Score: 0 — risk/low

Signal Detail Points
PR size 34 lines +0
Sensitive paths none +0

Computed by hyperfleet-risk-scorer

… config

MintMaker's global config overrides top-level packageRules with
manager-scoped gomod.packageRules. Moving the disable rules to the
same scope ensures they take precedence.

Signed-off-by: Rafael Benevides <rbenevid@redhat.com>
@rafabene rafabene force-pushed the HYPERFLEET-1351-fix-renovate-digest-config branch from c141328 to 52aba66 Compare July 13, 2026 22:53
@rafabene rafabene changed the title HYPERFLEET-1351: Fix Renovate config to properly disable gomod digest updates HYPERFLEET-1351 - fix: disable gomod digest updates in manager-scoped config Jul 13, 2026
@Ruclo

Ruclo commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci

openshift-ci Bot commented Jul 14, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ruclo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit c9efd9e into main Jul 14, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants