Skip to content

HYPERFLEET-1351 - fix: disable gomod digest updates in manager-scoped config#228

Merged
openshift-merge-bot[bot] merged 1 commit into
mainfrom
HYPERFLEET-1351-fix-renovate-digest-config
Jul 14, 2026
Merged

HYPERFLEET-1351 - fix: disable gomod digest updates in manager-scoped config#228
openshift-merge-bot[bot] merged 1 commit into
mainfrom
HYPERFLEET-1351-fix-renovate-digest-config

Conversation

@rafabene

Copy link
Copy Markdown
Member

Summary

  • Moved gomod digest and indirect disable rules from top-level packageRules to manager-scoped gomod.packageRules
  • This fixes an issue where MintMaker's global config was overriding the repo's disable rules due to Renovate's specificity hierarchy (manager-scoped rules take precedence over top-level rules)
  • No functional changes to minor/patch grouping or docker image grouping

JIRA

https://redhat.atlassian.net/browse/HYPERFLEET-1351

@openshift-ci openshift-ci Bot requested review from Mischulee and mbrudnoy July 13, 2026 22:49
@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

renovate.json moves the Go module-specific rules for disabling digest updates and indirect dependency updates into a top-level gomod.packageRules object. The remaining top-level packageRules entries stay in place.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: mbrudnoy, mischulee

🚥 Pre-merge checks | ✅ 11
✅ Passed checks (11 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Sec-02: Secrets In Log Output ✅ Passed Only renovate.json changed; no log statements with token/password/credential/secret fields or interpolations were added.
No Hardcoded Secrets ✅ Passed No hardcoded secrets found in renovate.json: no apiKey/secret/token/password literals, embedded creds, or long base64; only Renovate rule relocation. CWE-798 absent.
No Weak Cryptography ✅ Passed renovate.json only moved packageRules; no banned crypto (CWE-327/CWE-328/CWE-295) or secret comparisons were added.
No Injection Vectors ✅ Passed Only renovate.json changed; no new CWE-89/78/79/502 injection patterns were introduced in the diff.
No Privileged Containers ✅ Passed Only renovate.json changed; no manifests/templates/Dockerfiles or privileged-container patterns (CWE-250/CWE-284) in the diff.
No Pii Or Sensitive Data In Logs ✅ Passed Only renovate.json changed; no slog/logr/zap/fmt logging statements or data-bearing logs were added. No CWE-532 exposure found.
Title check ✅ Passed The title matches the Renovate gomod manager-scoped config fix; no mismatch or vague wording.
Description check ✅ Passed The description correctly explains the rule move and precedence fix; no off-topic or irrelevant content.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch HYPERFLEET-1351-fix-renovate-digest-config
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch HYPERFLEET-1351-fix-renovate-digest-config

Comment @coderabbitai help to get the list of available commands.

@hyperfleet-ci-bot

Copy link
Copy Markdown

Risk Score: 0 — risk/low

Signal Detail Points
PR size 34 lines +0
Sensitive paths none +0

Computed by hyperfleet-risk-scorer

… config

MintMaker's global config overrides top-level packageRules with
manager-scoped gomod.packageRules. Moving the disable rules to the
same scope ensures they take precedence.

Signed-off-by: Rafael Benevides <rbenevid@redhat.com>
@rafabene rafabene force-pushed the HYPERFLEET-1351-fix-renovate-digest-config branch from 1a3198e to ca98d8d Compare July 13, 2026 22:52
@rafabene rafabene changed the title HYPERFLEET-1351: Fix Renovate config to properly disable gomod digest updates HYPERFLEET-1351 - fix: disable gomod digest updates in manager-scoped config Jul 13, 2026
@rh-amarin

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci

openshift-ci Bot commented Jul 14, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rh-amarin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 8e5f65a into main Jul 14, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants