Skip to content

HYPERFLEET-1351 - fix: disable gomod digest updates in manager-scoped config#300

Merged
openshift-merge-bot[bot] merged 1 commit into
mainfrom
HYPERFLEET-1351-fix-renovate-digest-config
Jul 14, 2026
Merged

HYPERFLEET-1351 - fix: disable gomod digest updates in manager-scoped config#300
openshift-merge-bot[bot] merged 1 commit into
mainfrom
HYPERFLEET-1351-fix-renovate-digest-config

Conversation

@rafabene

Copy link
Copy Markdown
Member

Summary

  • Moved gomod digest and indirect disable rules from top-level packageRules to manager-scoped gomod.packageRules
  • This fixes an issue where MintMaker's global config was overriding the repo's disable rules due to Renovate's specificity hierarchy (manager-scoped rules take precedence over top-level rules)
  • No functional changes to minor/patch grouping or docker image grouping

JIRA

https://redhat.atlassian.net/browse/HYPERFLEET-1351

@openshift-ci openshift-ci Bot requested review from aredenba-rh and ldornele July 13, 2026 22:49
@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

The Renovate configuration moves the gomod-specific rules disabling digest and indirect dependency updates into a new top-level gomod block with nested packageRules. The existing schedule and remaining top-level package rules are retained.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: aredenba-rh, ldornele

🚥 Pre-merge checks | ✅ 11
✅ Passed checks (11 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Sec-02: Secrets In Log Output ✅ Passed PR only touches renovate.json; no non-test log statement changes or sensitive fields in logging code introduced (CWE-532).
No Hardcoded Secrets ✅ Passed No CWE-798/CWE-259 hardcoded secrets found in renovate.json; only Renovate rule relocation and no embedded credentials, private keys, or long base64 literals.
No Weak Cryptography ✅ Passed Only renovate.json changed; no crypto APIs, weak modes, SHA1-for-security, or secret comparisons found (no CWE-327/328/916).
No Injection Vectors ✅ Passed No CWE-89/78/79/502 injection patterns in the only changed file; renovate.json just relocates config rules.
No Privileged Containers ✅ Passed PR changes only renovate.json; no Kubernetes/OpenShift manifests, Helm templates, or Dockerfiles were touched, and the diff has no privileged-container flags.
No Pii Or Sensitive Data In Logs ✅ Passed PASS: The PR only edits renovate.json; no slog/logr/zap/fmt.Print* or other logging code was added, so no CWE-532-style data exposure surface.
Title check ✅ Passed The title matches the main change: moving gomod digest updates to manager-scoped config.
Description check ✅ Passed The description accurately describes the gomod rule move and its purpose, and stays on-topic.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch HYPERFLEET-1351-fix-renovate-digest-config
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch HYPERFLEET-1351-fix-renovate-digest-config

Comment @coderabbitai help to get the list of available commands.

@hyperfleet-ci-bot

Copy link
Copy Markdown

Risk Score: 0 — risk/low

Signal Detail Points
PR size 34 lines +0
Sensitive paths none +0

Computed by hyperfleet-risk-scorer

… config

MintMaker's global config overrides top-level packageRules with
manager-scoped gomod.packageRules. Moving the disable rules to the
same scope ensures they take precedence.

Signed-off-by: Rafael Benevides <rbenevid@redhat.com>
@rafabene rafabene force-pushed the HYPERFLEET-1351-fix-renovate-digest-config branch from e7858cf to fee00cd Compare July 13, 2026 22:53
@rafabene rafabene changed the title HYPERFLEET-1351: Fix Renovate config to properly disable gomod digest updates HYPERFLEET-1351 - fix: disable gomod digest updates in manager-scoped config Jul 13, 2026
@rh-amarin

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci

openshift-ci Bot commented Jul 14, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rh-amarin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit cd52794 into main Jul 14, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants